Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Confirm trashing changed data #348

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

WatanabeToshimitsu
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu commented Jan 11, 2022

What?

Confirm trashing changed data

Why?

簡単な操作ミスのせいで頑張って編集したデータが一瞬で消えると,大きなストレスになるので

See also

Related: dataware-tools/dataware-tools#104

Screenshot or video

ConfirmTrashingChangedData

@hdl-service hdl-service requested a review from d-hayashi January 11, 2022 07:31
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2022
@WatanabeToshimitsu
Copy link
Contributor Author

WatanabeToshimitsu commented Jan 11, 2022

とりあえず,コード的にもUX的にも変更の少なそうな「変更があったら確認モーダルを出す」を実装しました!

Copy link
Contributor

@d-hayashi d-hayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-hayashi, WatanabeToshimitsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,d-hayashi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 76b80f6 into master Jan 12, 2022
@hdl-service hdl-service deleted the feature/confirm-closing-config-setting-modal branch January 12, 2022 01:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants