Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Confirm closing window when changed data exists #366

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

WatanabeToshimitsu
Copy link
Contributor

What?

Confirm closing window when changed data exists

Why?

誤操作で変更中のデータが吹っ飛ぶのを防ぎたいから

See also

Related : dataware-tools/dataware-tools#117

Screenshot or video

See dataware-tools/app-common#208

@hdl-service hdl-service requested a review from d-hayashi January 24, 2022 09:34
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2022
Copy link
Contributor

@d-hayashi d-hayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-hayashi, WatanabeToshimitsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,d-hayashi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@d-hayashi d-hayashi merged commit 5bfabe9 into master Jan 25, 2022
@hdl-service hdl-service deleted the fix/confirm-closing-window branch January 25, 2022 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants