Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Fix the feature of downloading metadata #372

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Conversation

d-hayashi
Copy link
Contributor

What?

メタ情報のエクスポート機能で以下の点を修正:

  • csvでの出力時に無駄に " で囲われる問題を修正
  • カラム名が display_name に変換されていなかった問題を修正
  • ファイルパスに / など不要なものが含まれていた問題を修正

Why?

バグ修正のため

@hdl-service hdl-service requested a review from yusukefs January 25, 2022 03:39
@hdl-service hdl-service added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
@d-hayashi d-hayashi requested review from WatanabeToshimitsu and removed request for yusukefs January 25, 2022 03:39
@hdl-service hdl-service added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2022
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

例の如く細かいとこをいくつか
let 撲滅とか、宗教的なとこは無視してもらって全然大丈夫です

src/components/organisms/ExportMetadataModal.tsx Outdated Show resolved Hide resolved
src/components/organisms/ExportMetadataModal.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-hayashi, WatanabeToshimitsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,d-hayashi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@d-hayashi d-hayashi merged commit e813491 into master Jan 26, 2022
@hdl-service hdl-service deleted the fix/download-metadata branch January 26, 2022 05:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants