Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBASSADOR_SINGLE_NAMESPACE should be true/false not set/unset #1387

Closed
ryandawsonuk opened this issue Mar 29, 2019 · 3 comments
Closed

AMBASSADOR_SINGLE_NAMESPACE should be true/false not set/unset #1387

ryandawsonuk opened this issue Mar 29, 2019 · 3 comments
Labels
stale Issue is stale and will be closed

Comments

@ryandawsonuk
Copy link

If you set the env var AMBASSADOR_SINGLE_NAMESPACE to false, ambassador still only watches resources in that namespace. If you don't set the env var at all, then it watches all namespaces.

This has been noted before - #588 (comment)

I believe it is because of https://github.com/datawire/ambassador/blob/335e58e440fd81693310d84e370e576be8d96655/ambassador/kubewatch.py#L28 , which isn't doing a check on the value - https://stackoverflow.com/a/30015489

@stale
Copy link

stale bot commented Jun 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Jun 5, 2019
@ryandawsonuk
Copy link
Author

ryandawsonuk commented Jun 5, 2019

This is less important now helm/charts#12670 is merged as it can now easily be set or not set via a parameter in the helm chart

@stale stale bot removed the stale Issue is stale and will be closed label Jun 5, 2019
@stale
Copy link

stale bot commented Aug 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Aug 4, 2019
@stale stale bot closed this as completed Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue is stale and will be closed
Projects
None yet
Development

No branches or pull requests

1 participant