Fix issue #1637: setDay with weekStartsOn != 0 #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
reviewed
Feb 14, 2020
|
🙏 @dcousens : can you approve this PR since the change has been taken into consideration?
|
|
@boomdev : have you checked if "lastDayOfWeek startOfWeek differenceInCalendarWeeks" are fixed? |
|
@trollepierre I am not a maintainer, I am merely a fellow user wanting to help 👍 |
@trollepierre I have not. |
dkozickis
approved these changes
Mar 30, 2020
|
Thank you @boomdev and @dcousens, this seems GTG. |
added 3 commits
April 9, 2020 19:26
As demonstrated in the issue, setDay(date, day, [option]) returns an
incorrect value if date is on a Sunday and option.weekStartsOn is != 0.
This includes a fix (there's probably a nicer way to code this) and
2 corresponding test cases.
I also found 4 test cases that I believe to be incorrect, all using
the argument {weekStartsOn: 1}. I hope I'm not mistaken here, but I
changed the test cases accordingly.
- All tests completed
- Build script run
- Added entry to Unreleased section of CHANGELOG
kossnocorp
force-pushed
the
fix-issue-1637
branch
from
0920734
to
9d528ab
Compare
|
@dkozickis yeah, some tests were failing because of a DST issue that was fixed in master. I've rebased the branch but there's still a couple failing tests in the changed function. I'm on it. |
This was referenced Apr 11, 2020
kossnocorp
added a commit
that referenced
this pull request
Apr 14, 2020
Pyppe
pushed a commit
to Pyppe/date-fns
that referenced
this pull request
Apr 16, 2020
Co-authored-by: Sasha Koss <koss@nocorp.me>
This was referenced May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As demonstrated in the issue, setDay(date, day, [option]) returns an
incorrect value if date is on a Sunday and option.weekStartsOn is != 0.
This includes a fix (there's probably a nicer way to code this) and
2 corresponding test cases.
I also found 4 test cases that I believe to be incorrect, all using
the argument {weekStartsOn: 1}. I hope I'm not mistaken here, but I
changed the test cases accordingly.
All tests completed
Build script run
Added entry to Unreleased section of CHANGELOG