Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add West Frisian (fy) support #2183

Merged
merged 7 commits into from
Dec 12, 2021
Merged

Conversation

damon02
Copy link
Contributor

@damon02 damon02 commented Feb 1, 2021

This adds the West Frisian language spoken in the North of the Netherlands to date-fns.

@damon02
Copy link
Contributor Author

damon02 commented Feb 22, 2021

Hmm no activity here yet, let me explain how and what I based this PR on 😄

For this pull request I worked together with the Provincie Fryslân (where the language is spoken) and had somebody translate and help me put this translation together. I have direct contacts with people at the province through my company, which we use this library for.

I also cross checked this with https://unicode.org/cldr/cldr-aux/charts/32/summary/fy.html#1882 and it seems to match, although that page actually has some words in Dutch and not in Frisian, where the PR has these translated correctly.

I didn't see the PR checklist when creating my PR but when browsing at others it seemed missing so, here you go:


PR Checklist

To maintain date-fns top quality, please check if PR fulfills the main contributing requirements:

[x] PR follows style guides specified on the guideline: Contributing Guide
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[ ] Any changes made on the changelog.
[ ] Any changes made on the library version.
[x] Prior to sending pull request FP functions, typings and indices were rebuilt.

What is the new behavior?

With this PR, date-fns will start to support the Frisian (fy) language.

Does this PR introduce a breaking change?

* [ ] Yes
* [x] No

@tan75 tan75 self-assigned this Apr 18, 2021
@tan75 tan75 self-requested a review April 18, 2021 20:24
@tan75
Copy link
Contributor

tan75 commented Apr 18, 2021

hi @damon02
Apologies for the delay! could you please resolve the conflicts, then run yarn locale-snapshots again (just in case) and push up your code?

@damon02
Copy link
Contributor Author

damon02 commented May 3, 2021

I resolved the conflicts by making the PR up to date again with the upstream master branch and re-ran the yarn locale-snapshots command and pushed this.

Copy link
Contributor

@tan75 tan75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! 🙏

@tan75 tan75 mentioned this pull request Dec 4, 2021
24 tasks
@leshakoss leshakoss merged commit da1b9e9 into date-fns:master Dec 12, 2021
tan75 pushed a commit to janziemba/date-fns that referenced this pull request Dec 27, 2021
Added West Frisian (`fy`) locale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants