-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Greek locale files (el) #334
Conversation
bf0aead
to
7c1fdda
Compare
@teoulas thanks a lot! 🌟
What about "Do MMMM"? |
'Q': 'ο', | ||
'W': 'η' | ||
} | ||
Object.keys(ordinalGenders).map(function (formatterToken) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teoulas Please don't use Object.keys
(it doesn't work in IE8, sadly). Separate array which is a copy of Object.keys(ordinalGenders)
is ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IE8? Wow, I completely forgot that! I'll change it.
Good point about "Do MMMM". It's not a common format, but momentjs supports it correctly. I will take a look. |
In Russian locale we made it like this: |
@leshakoss thanks for the tip, that's exactly how I implemented it as well! |
@teoulas great work! Please fix the linting problem and we're good to go https://travis-ci.org/date-fns/date-fns/builds/183575458#L230 |
fb5f355
to
fb5f99b
Compare
Fixed linting and squashed commits. Good to go. 🚀 |
@teoulas thank you for your contribution! 🇬🇷 Greek locale was released with 1.19.0 (diff: v1.18.0...v1.19.0) |
👍 Thanks for the super quick response and new release! |
Support for Greek.
Greek has genders and some formats ("D MMMM" and "DD MMMM") should output the month in genitive.