Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch: improve jql integration #139

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Conversation

mhuang74
Copy link
Contributor

@mhuang74 mhuang74 commented Jan 4, 2022

Improve JQL integration for Fetch (#77)

  • added better error messaging for jql errors
  • added support for multi-value selectors by concatenating them into comma separated string (e.g. "Anaheim, CA")
  • added support for JSON Number types properly
  • added usage examples in Fetch.md
  • refactored and added unit tests for jql integration
  • added integration test for multi-value jql selector
  • added errors for unsupported CLI params
mhuang@twisted-linen:~/Projects/rust/qsv (fetch-fix-jql)$ cargo test fetch
    Finished test [optimized + debuginfo] target(s) in 0.29s
     Running unittests (target/debug/deps/qsv-018ebfd29fc3825d)

running 5 tests
test cmd::fetch::test_apply_jql_null ... ok
test cmd::fetch::test_apply_jql_bool ... ok
test cmd::fetch::test_apply_jql_array ... ok
test cmd::fetch::test_apply_jql_number ... ok
test cmd::fetch::test_apply_jql_string ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/qsvlite-51c40fd03267f4fc)

running 5 tests
test cmd::fetch::test_apply_jql_null ... ok
test cmd::fetch::test_apply_jql_bool ... ok
test cmd::fetch::test_apply_jql_number ... ok
test cmd::fetch::test_apply_jql_array ... ok
test cmd::fetch::test_apply_jql_string ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/tests.rs (target/debug/deps/tests-df10d0df673cea23)

running 4 tests
test test_fetch::fetch_jql_single ... ok
test test_fetch::fetch_jql_multiple ... ok
test test_fetch::fetch_simple ... ok
test test_fetch::fetch_ratelimit ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 616 filtered out; finished in 9.03s

@mhuang74 mhuang74 changed the title Fetch:improve jql integration Fetch: improve jql integration Jan 4, 2022
@jqnatividad jqnatividad merged commit d28d626 into dathere:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants