-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch: enable cookies and storing error messages #141
Conversation
…k with single-thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @mhuang74 ,
The fetch_ratelimit
test is failing for "Hefty Smurf" - the 5th element with --rate-limit
set to 4.
Perhaps the result is inadvertently dropped when you reach the limit? But why only in Windows?
At first, I thought it might be a Github Actions runner issue, but I even tried running your PR locally on my Windows laptop and I got the same error.
Thanks @jqnatividad. I've increased burst size to 7, while keeping everything else the same, to see if error goes away. Other issues corrected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closing as GH is giving false positive unmerged commits message, but it got merged just the same... |
Confirmed that all 8 commits have been merged into master. Thanks @jqnatividad! Probably user error in VSCode that this commit got pushed to upstream directly. Oops. UPDATE: nevermind, wasn't reading the unsquashed commit history correctly...all good. |
Fetch: enable cookies and storing error messages
Improve Fetch (#77) with cookies and storing error messages.
--store-error
flag.--cookies
flag.--jobs
param since single-thread may be fast enough for most usecases.