Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch: support custom http headers #143

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

mhuang74
Copy link
Contributor

@mhuang74 mhuang74 commented Jan 8, 2022

Support setting one or more custom http headers for fetch (#77):

  • primary usecase is to set api keys. since each api requires different keys, it seems simpler to just set via args and not bother with config files for now
  • to support config file, qsv should probably just have one single config file with command specific sections, and maybe even support profiles
  • header format "key:value" uses ':' colon as separator
  • integration test uses http://httpbin.org/get to confirm that custom headers are passed to server (thanks @jqnatividad for suggesting this)
  • fixed bug with white space in URL column

@jqnatividad jqnatividad merged commit 6bbeffb into dathere:master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants