Prevent LazyLoadingViolationException when using strict mode #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using the package in conjunction with strict models, editing a menu will fail due to a
LazyLoadingViolationException
since thelinkable
is not eager loaded with theMenuItems
. This pull request fixes that, making the package compatible with strict mode as far as I can tell.Although usually the use of
$with
is discouraged, it seems theMenuItem
class heavily relies on the relationship anywhere it is used. In the future, this could be improved by introducing specific->with()
calls on the various queries, but this should go a long way and shouldn't be too egregious.The following should now work in the app's service provider: