-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add omit_columns
option to mermaid
#77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syou6162
force-pushed
the
feature/add_omit_columns
branch
from
February 8, 2024 06:19
b9a3f5c
to
3c64a87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 85.60% 85.68% +0.07%
==========================================
Files 31 31
Lines 910 915 +5
==========================================
+ Hits 779 784 +5
Misses 131 131 ☔ View full report in Codecov by Sentry. |
syou6162
force-pushed
the
feature/add_omit_columns
branch
from
February 8, 2024 06:31
349b1cc
to
3cb9cd4
Compare
syou6162
force-pushed
the
feature/add_omit_columns
branch
from
February 8, 2024 06:33
3cb9cd4
to
7f01392
Compare
datnguye
reviewed
Feb 8, 2024
syou6162
force-pushed
the
feature/add_omit_columns
branch
from
February 8, 2024 12:03
be933b8
to
b172040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #78
Description
I added
--omit_columns
option to omit columns from diagrams when the output format is mermaid.I thought about omitting columns for
--target
other than mermaid, but since dbml, for example, requires at least one column, I decided to support only--target = mermaid
.Checklist