Allow gatsby-plugin-image v2 as peer dependency #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using gatsby-plugin-image@2.1.0 with gatsby-source-datocms@3.0.10 and it has worked really well for us so far.
Looking at the CHANGELOG for gatsby-plugin-image@2.2.0 the only thing I can see that prompts a major version bump is gatsbyjs/gatsby#32544 (basically when using multiple sources you need to include
gatsby-plugin-imagein yourgatsby-config.js) but the commit itself isn't marked as a breaking change. So I don't really know. Maybe the major version bump was for Gatsby to be able to say that Gatsby v4 requires v2+ ofgatsby-plugin-image? 🤷♂️Either way, I manually checled the diff between 1.14.2 and 2.2.0 and I can't see any reason for the major version bump other than the above. The diff is basically only version bumps to dependencies, devDependencies and peerDependencies.
This PR would allow more flexibility for consumers of
gatsby-source-datocms.