-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate flowershow packages #923
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 9 Ignored Deployments
|
- also temporarily force any type on htmlExtension
0461888
to
dc4646b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to: datopian/flowershow#509
Summary
4 packages moved from the Flowershow repository:
core
,remark-embed
,remark-wiki-link
,remark-callout
. These are now going to be published under@portaljs
scope.Note that all these packages are using Nx's
project.json
files for project configurations.Changes
package.json
Notes
cc: @demenech, @luccasmmg, @rufuspollock
For the future, I'd advise moving all the dev dependencies of
components
andckan
packages to the root as well. They are not ever used/installed by their users anyway. And this way you can also prevent having to manage different versions of one dev dependency across different projects. You have only one for all.As you can see there are a lot of duplicate dev deps:
ckan:
components:
And some of them are already included in the root
package.json
...