Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate flowershow packages #923

Merged
merged 33 commits into from
Jun 7, 2023
Merged

Conversation

olayway
Copy link
Member

@olayway olayway commented Jun 5, 2023

Related to: datopian/flowershow#509

Summary

4 packages moved from the Flowershow repository: core, remark-embed, remark-wiki-link, remark-callout. These are now going to be published under @portaljs scope.
Note that all these packages are using Nx's project.json files for project configurations.

Changes

Notes

cc: @demenech, @luccasmmg, @rufuspollock

For the future, I'd advise moving all the dev dependencies of components and ckan packages to the root as well. They are not ever used/installed by their users anyway. And this way you can also prevent having to manage different versions of one dev dependency across different projects. You have only one for all.

As you can see there are a lot of duplicate dev deps:

ckan:

  "devDependencies": {
    "@storybook/addon-essentials": "^7.0.7",
    "@storybook/addon-interactions": "^7.0.7",
    "@storybook/addon-links": "^7.0.7",
    "@storybook/blocks": "^7.0.7",
    "@storybook/react": "^7.0.7",
    "@storybook/react-vite": "^7.0.7",
    "@storybook/testing-library": "^0.0.14-next.2",
    "@types/react": "^18.0.28",
    "@types/react-dom": "^18.0.11",
    "@typescript-eslint/eslint-plugin": "^5.57.1",
    "@typescript-eslint/parser": "^5.57.1",
    "@vitejs/plugin-react": "^4.0.0",
    "autoprefixer": "^10.4.14",
    "eslint": "^8.38.0",
    "eslint-plugin-react-hooks": "^4.6.0",
    "eslint-plugin-react-refresh": "^0.3.4",
    "json": "^11.0.0",
    "postcss": "^8.4.23",
    "prop-types": "^15.8.1",
    "tailwindcss": "^3.3.2",
    "typescript": "^5.0.2",
    "vite": "^4.3.2",
    "vite-plugin-dts": "^2.3.0"
  },

components:

  "devDependencies": {
    "@storybook/addon-essentials": "^7.0.7",
    "@storybook/addon-interactions": "^7.0.7",
    "@storybook/addon-links": "^7.0.7",
    "@storybook/blocks": "^7.0.7",
    "@storybook/react": "^7.0.7",
    "@storybook/react-vite": "^7.0.7",
    "@storybook/testing-library": "^0.0.14-next.2",
    "@types/flexsearch": "^0.7.3",
    "@types/papaparse": "^5.3.7",
    "@types/react": "^18.0.28",
    "@types/react-dom": "^18.0.11",
    "@typescript-eslint/eslint-plugin": "^5.57.1",
    "@typescript-eslint/parser": "^5.57.1",
    "@vitejs/plugin-react": "^4.0.0",
    "autoprefixer": "^10.4.14",
    "eslint": "^8.38.0",
    "eslint-plugin-react-hooks": "^4.6.0",
    "eslint-plugin-react-refresh": "^0.3.4",
    "eslint-plugin-storybook": "^0.6.11",
    "json": "^11.0.0",
    "postcss": "^8.4.23",
    "prop-types": "^15.8.1",
    "storybook": "^7.0.7",
    "tailwindcss": "^3.3.2",
    "typescript": "^5.0.2",
    "vite": "^4.3.2",
    "vite-plugin-dts": "^2.3.0"
  },

And some of them are already included in the root package.json...

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

⚠️ No Changeset found

Latest commit: dc4646b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
portaljs-alan-turing ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am
portaljs-ckan ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am
portaljs-ckan-ssg ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am
portaljs-fivethirtyeight ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am
portaljs-git-example ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am
portaljs-learn ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am
portaljs-openspending ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am
portaljs-storybook ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am
site-portaljs ⬜️ Ignored (Inspect) Jun 7, 2023 9:47am

@olayway olayway marked this pull request as ready for review June 7, 2023 09:34
@olayway olayway changed the title 🚧 Integrate flowershow packages Integrate flowershow packages Jun 7, 2023
@olayway olayway force-pushed the integrate-flowershow-packages branch from 0461888 to dc4646b Compare June 7, 2023 09:46
Copy link
Member

@luccasmmg luccasmmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luccasmmg luccasmmg merged commit af134ca into main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants