Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting Themeprovider from Core #440

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Exporting Themeprovider from Core #440

merged 3 commits into from
Feb 27, 2023

Conversation

PhilippeduPreez
Copy link
Contributor

closes #386

Summary

  • removed next-themes package from template
  • export ThemeProvider from core

Notes

  • Theme switch works locally and build passes
  • Want to make sure this does not cause any problems/changes with the CLI tool

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2023

🦋 Changeset detected

Latest commit: 68d4f05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@flowershow/template Minor
@flowershow/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for spectacular-dragon-c1015c ready!

Name Link
🔨 Latest commit 68d4f05
🔍 Latest deploy log https://app.netlify.com/sites/spectacular-dragon-c1015c/deploys/63f8f0498582b500084b3023
😎 Deploy Preview https://deploy-preview-440--spectacular-dragon-c1015c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khalilcodes
Copy link
Contributor

khalilcodes commented Feb 27, 2023

@PhilippeduPreez @olayway we might not need to do this, see comment in issue.

But then again, maybe it's best to have one instance of "next-themes" that comes from flowershow anyways.

@olayway olayway merged commit 0d198b8 into main Feb 27, 2023
@olayway olayway deleted the 386-Theme-switch branch May 8, 2023 10:57
rufuspollock pushed a commit to rufuspollock/flowershow that referenced this pull request Oct 27, 2023
olayway added a commit that referenced this pull request Oct 31, 2023
Exporting Themeprovider from Core
olayway added a commit that referenced this pull request Oct 31, 2023
Exporting Themeprovider from Core
olayway added a commit that referenced this pull request Oct 31, 2023
Exporting Themeprovider from Core
olayway added a commit that referenced this pull request Oct 31, 2023
Exporting Themeprovider from Core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme switch (dark / light) bug (on our website)
3 participants