Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mermaid #446

Merged
merged 9 commits into from
Mar 1, 2023
Merged

Update mermaid #446

merged 9 commits into from
Mar 1, 2023

Conversation

khalilcodes
Copy link
Contributor

@khalilcodes khalilcodes commented Feb 28, 2023

closes #428

Summary

This PR updates the mermaid dependency and fixes mermaid hydration errors.

Changes

  • Update mermaid in core v10.0.1-rc.2
  • create mermaid component
  • add mdx-mermaid plugin in template
  • remove remark-code-extra plugin

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

🦋 Changeset detected

Latest commit: aaea33f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@flowershow/template Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 28, 2023

Deploy Preview for spectacular-dragon-c1015c ready!

Name Link
🔨 Latest commit aaea33f
🔍 Latest deploy log https://app.netlify.com/sites/spectacular-dragon-c1015c/deploys/63ff45c5bf2f930008ae3e81
😎 Deploy Preview https://deploy-preview-446--spectacular-dragon-c1015c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@olayway olayway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

packages/template/pages/[[...slug]].tsx Outdated Show resolved Hide resolved
Copy link
Member

@olayway olayway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overrides field with mermaid in package.json file should be removed now.

@khalilcodes khalilcodes merged commit 4608694 into main Mar 1, 2023
@khalilcodes khalilcodes deleted the 428-update-mermaid branch March 7, 2023 11:24
rufuspollock pushed a commit to rufuspollock/flowershow that referenced this pull request Oct 27, 2023
Update mermaid

closes datopian#428 

* Update mermaid in core `v10.0.1-rc.2`
* create mermaid component in core
* add `mdx-mermaid` plugin and mermaid component in template
* remove `remark-code-extra` plugin
olayway pushed a commit that referenced this pull request Oct 31, 2023
Update mermaid

closes #428 

* Update mermaid in core `v10.0.1-rc.2`
* create mermaid component in core
* add `mdx-mermaid` plugin and mermaid component in template
* remove `remark-code-extra` plugin
olayway pushed a commit that referenced this pull request Oct 31, 2023
Update mermaid

closes #428 

* Update mermaid in core `v10.0.1-rc.2`
* create mermaid component in core
* add `mdx-mermaid` plugin and mermaid component in template
* remove `remark-code-extra` plugin
olayway pushed a commit that referenced this pull request Oct 31, 2023
Update mermaid

closes #428 

* Update mermaid in core `v10.0.1-rc.2`
* create mermaid component in core
* add `mdx-mermaid` plugin and mermaid component in template
* remove `remark-code-extra` plugin
olayway pushed a commit that referenced this pull request Oct 31, 2023
Update mermaid

closes #428 

* Update mermaid in core `v10.0.1-rc.2`
* create mermaid component in core
* add `mdx-mermaid` plugin and mermaid component in template
* remove `remark-code-extra` plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError: Named export 'o' not found. The requested module './mermaid.95cd9c8e.js' is a CommonJS module
2 participants