Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated features #448

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Updated features #448

merged 4 commits into from
Mar 6, 2023

Conversation

PhilippeduPreez
Copy link
Contributor

closes #247

Changes

  • added Feature component in site/components
  • added Features component in site/components
  • imported Features component in site/index

Notes

  • any features can easily be added or removed in site/components/Features

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023

⚠️ No Changeset found

Latest commit: ad68bf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for spectacular-dragon-c1015c ready!

Name Link
🔨 Latest commit ad68bf2
🔍 Latest deploy log https://app.netlify.com/sites/spectacular-dragon-c1015c/deploys/6405fd544663f30007324716
😎 Deploy Preview https://deploy-preview-448--spectacular-dragon-c1015c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@olayway olayway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, I think it's a good improvement, but the design of feature sections doesn't really match the rest of the page. I.e. I'd either keep old plain headings everywhere or use the new colorful ones on the whole page. Same goes for screenshots -we're not using drop shadows anywhere. Also, aren't we missing sth from the features list?

@PhilippeduPreez
Copy link
Contributor Author

@olayway Changes made :) Let me know if the images are big enough please

@olayway
Copy link
Member

olayway commented Mar 6, 2023

LGTM :)

For the future: maybe we could find a better-looking example of a custom theme and show some nice Tailwind styled page on our site.

@PhilippeduPreez PhilippeduPreez merged commit 225bab3 into main Mar 6, 2023
@olayway olayway deleted the 247-Feature-Section branch May 8, 2023 10:57
rufuspollock pushed a commit to rufuspollock/flowershow that referenced this pull request Oct 27, 2023
* [site/components][s]: Updated features
olayway pushed a commit that referenced this pull request Oct 31, 2023
* [site/components][s]: Updated features
olayway pushed a commit that referenced this pull request Oct 31, 2023
* [site/components][s]: Updated features
olayway pushed a commit that referenced this pull request Oct 31, 2023
* [site/components][s]: Updated features
olayway pushed a commit that referenced this pull request Oct 31, 2023
* [site/components][s]: Updated features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature section v0.2 on the front page
2 participants