To bytes #17
Merged
To bytes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps the code to use Rust 2018.
Even tho datrs#2 was closed with the iter implementation, it was not enought to use with `bitfield-rle` crate. The crate takes a `AsRef<[u8]>` to encode, and the iterator returns a set of `bool`. This code uses the `Bitfield.prototype.toBuffer` logic to create the `to_bytes` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even tho #2 was closed
with the iter implementation, it was not enought to use with
bitfield-rlecrate.The crate takes a
AsRef<[u8]>to encode, and the iterator returns aset of
bool. This code uses theBitfield.prototype.toBufferlogic tocreate the
to_bytesmethod.Choose one: a 🙋 feature
Checklist
Context
Built on top of #16
Semver Changes
minor