Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Broken theme after latest update #2076

Closed
2 tasks done
random2907 opened this issue Jan 6, 2025 · 20 comments
Closed
2 tasks done

[BUG] Broken theme after latest update #2076

random2907 opened this issue Jan 6, 2025 · 20 comments
Labels
Milestone

Comments

@random2907
Copy link

Rofi version (rofi -v)

Version: 1.7.7-dirty

Configuration

https://gist.github.com/random2907/6ff1c20637bb502cd4359071264fd6f0

Theme

https://gist.github.com/random2907/51458d5a7d8494f5f62241aafeb683a6

Timing report

https://gist.github.com/random2907/f38797e60ab5a7303a72a12f12864d22

Launch command

rofi -show drun

Step to reproduce

use the theme and config after git bisect the problem is this commit 3b1e483

Expected behavior

1736183388

Actual behavior

1736183412

Additional information

No response

Using wayland display server protocol

  • No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

  • Yes, I have checked the problem exists in the latest stable version
@random2907 random2907 added the bug label Jan 6, 2025
@DaveDavenport
Copy link
Collaborator

owh fun :( Thanks for reporting and bisecting.

DaveDavenport added a commit that referenced this issue Jan 6, 2025
@DaveDavenport
Copy link
Collaborator

This is a bug, but odd theme, given it has borders but in same color as background.
Quick work-around would be setting border-color it to 'transparent'.

@DaveDavenport
Copy link
Collaborator

Git should fix this.

@237dmitry
Copy link

I also couldn't set the correct border color, it's semi-transparent:

border: 1px solid;
border-color: #aabbcc;     //    semi-transparent as #aabbcc88

@DaveDavenport
Copy link
Collaborator

If you could test rofi-git to see if it works with the latest change, that would be very useful.

@237dmitry
Copy link

f you could test rofi-git to see if it works with the latest change, that would be very useful.

aur/rofi-git 1.7.5.r90.g82b2ce94-1 [+70 ~0.72] [Out-of-date: 2024-12-28]

$ rofi -version
Version: 1.7.7-dirty

@Linus-Mussmaecher
Copy link

In the AUR, rofi-git is marked out of date since 2024-12-28 (as pointed out above), but uninstalling rofi and installing rofi-git fixes the issue.

@237dmitry
Copy link

but uninstalling rofi and installing rofi-git fixes the issue.

I don't want to downgrade Rofi's version, I think it's better to wait. Now I set the borders to 0, not so pretty, but bearable.

@lbonn
Copy link
Collaborator

lbonn commented Jan 7, 2025

but uninstalling rofi and installing rofi-git fixes the issue.

I don't want to downgrade Rofi's version, I think it's better to wait. Now I set the borders to 0, not so pretty, but bearable.

The bug has been fixed on the latest development branch (next)

Waiting is fine but installing rofi-git from AUR instead of rofi is not "downgrade rofi's version", on the contrary you'd be using the latest development version. Flip side is, of course, that new regressions can pop there as well.

@237dmitry
Copy link

but installing rofi-git from AUR instead of rofi is not "downgrade rofi's version"

There is 1.7.5 but current is 1.7.7

@lbonn
Copy link
Collaborator

lbonn commented Jan 7, 2025

@237dmitry The packages ending with -git (eg rofi-git) in AUR are tagged to some arbitrary version until someone updates it but if you build it you will see that it actually takes the tip of the upstream repository.

So in summary, do not trust this 1.7.5

@237dmitry
Copy link

Thanks, Ok, I built the package and installed it instead of rofi-1.7.7 and it works as expected. Borders are fine.

Version: 1.7.7-4-g60181710 (makepkg)

I'm waiting for the new release, though.

@DaveDavenport
Copy link
Collaborator

If more people would test, these thing could be caught before a release. By helping to test, you also help us avoid these issues.

The fix (of another issue) that caused passed most of my tests, but it is hard to catch all cases. (this is why i also committed your theme as test-case).

@ACR-Jeff
Copy link

ACR-Jeff commented Jan 8, 2025

Same issue in Void Linux after updating to 1.7.7

My theme
Rofi-MyTheme

With border issues
Border-Issues

@Oglo12
Copy link

Oglo12 commented Jan 15, 2025

I've had the same issue.

Before updating (just fine, do note that this screenshot is from one of my YouTube videos, so the quality is questionable):
image

After updating (now I have these weird dark and light spots):
image

Here is my current config: https://0x0.st/8o9e.tar.gz (0x0.st is just an easy way to share files.)

@Oglo12
Copy link

Oglo12 commented Jan 15, 2025

Idk if it helps, but I am using Hyprland, so I am using the Wayland version of Rofi.

@Oglo12
Copy link

Oglo12 commented Jan 15, 2025

image

@DaveDavenport
Copy link
Collaborator

DaveDavenport commented Jan 16, 2025

@Oglo12 did the fix in this issue fix this? or are you just repeating what already been reported, confirmed and possible fixed?

rules.

@Oglo12
Copy link

Oglo12 commented Jan 16, 2025

@Oglo12 did the fix in this issue fix this? or are you just repeating what already been reported, confirmed and possible fixed?

rules.

Sorry, I saw the issue was open, so I figured I would add to it. I also linked another config in case that would help.

@lbonn
Copy link
Collaborator

lbonn commented Jan 16, 2025

Yes I think we can close the issue as the fix is in next.

@Oglo12 it's also fixed on the latest wayland tip but not in a release yet, lbonn#164

@lbonn lbonn closed this as completed Jan 16, 2025
@DaveDavenport DaveDavenport added this to the 1.7.8 milestone Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants