Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default http client initializing. #4

Merged
merged 1 commit into from
May 13, 2022

Conversation

MikDal002
Copy link
Contributor

Hello!
I've tried to use this library and unfortunately came across the bug. Here is the fix :).

@daveaglick
Copy link
Owner

Thanks! So to make sure I understand the issue here, it's when you pass null into the constructor for an HttpClient? Seems like a nice defensive fix to check for that.

@daveaglick daveaglick merged commit 0fafd31 into daveaglick:main May 13, 2022
@MikDal002
Copy link
Contributor Author

I used var myClient = new NetlifyClient("my-access-code");. It was enough to came across this problem :). I'm glad that you merged those changes :).

@MikDal002 MikDal002 deleted the bugfix/default-httpclient branch May 14, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants