deleted photoz_helper script #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrophpeter
changed the title
davecoulter
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # NA
Description of the Change
Removing the the old photoz_helper.py script which is in the base directory. This module is in the astro_ghost python package now, and everywhere in yse_pz (except in YSE_App/data_ingest/PS1_PhotoZ.py) photoz_helper is imported from astro_ghost - So this script deletion should not effect the django web app.
YSE_App/data_ingest/PS1_PhotoZ.py is a cron that is not currently being run on production, and could potentially break with this deletion. We should test if we can import photoz_helper via the astro_ghost module in this cron. I've updated the imports in this file. Could just also delete this unused cron? (it will still be in git history ofcourse).
Checklist
Please check all that apply to your proposed changes
Additional context