feat: Work Order PDF Generation Service (Story 12.1)#187
Merged
daveharmswebdev merged 2 commits intomainfrom Feb 6, 2026
Merged
feat: Work Order PDF Generation Service (Story 12.1)#187daveharmswebdev merged 2 commits intomainfrom
daveharmswebdev merged 2 commits intomainfrom
Conversation
Implement backend service to generate professional work order PDFs via
POST /api/v1/work-orders/{id}/pdf. Follows existing ScheduleE PDF pattern
using QuestPDF. Includes header with status badge, property info, work order
details, vendor/DIY assignment, notes, linked expenses table, photo count
note, and branded footer with page numbers. 9 unit tests, 913 total passing.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code review fixes for work order PDF generation (PR #187): - CRITICAL: Add explicit AccountId filter to query (defense-in-depth) - Add AsNoTracking() to all three read-only queries (performance) - Add validator injection and call in controller endpoint (consistency) - Capture DateTime.UtcNow once to prevent midnight-boundary drift - Remove redundant DeletedAt filters (global query filter handles it) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v1/work-orders/{id}/pdfendpoint that generates a professional PDF document for any work orderTest plan
🤖 Generated with Claude Code