feat: Add work order PDF download and preview (Story 12.2)#188
Merged
daveharmswebdev merged 2 commits intomainfrom Feb 6, 2026
Merged
Conversation
Add PDF download and preview functionality to the work order detail page, covering FR50 (Download) and FR51 (Preview). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix subscription leaks in onDownloadPdf() and loadPdf() by storing subscriptions and cleaning up in ngOnDestroy(). Add null guards for response.body instead of non-null assertions. Strengthen filename extraction tests to verify actual filename usage. Remove unused imports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkOrderPdfPreviewDialogComponentwith zoom controls (50-200%), print, download, and closegenerateWorkOrderPdf()method toWorkOrderServicewith Content-Disposition filename extractionTest plan
🤖 Generated with Claude Code