Skip to content

Commit

Permalink
Fixes "Coverage Trend Indicator" for pull requests with slash ('/') i…
Browse files Browse the repository at this point in the history
…n the name

Artifacts cannot have forward slashes ('/') in the name, which causes dependabot tests to fail and could also impact gitflow and other systems that use slashes in the branch names.
  • Loading branch information
jimkring authored Nov 11, 2024
1 parent 554e814 commit 804920f
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
branch:
- ${{ github.head_ref }}
- "main"
include:
- branch: main
artifact: main
- branch: ${{ github.head_ref }}
artifact: pull-request
permissions:
# Required to checkout the code
Expand All @@ -193,7 +195,7 @@ jobs:
- name: "Upload Coverage"
uses: actions/upload-artifact@v4
with:
name: coverage-${{ matrix.branch }}
name: coverage-${{ matrix.artifact }}
path: coverage
report-coverage:
Expand All @@ -203,7 +205,7 @@ jobs:
- name: "Download Coverage Artifacts"
uses: actions/download-artifact@v4
with:
name: coverage-${{ github.head_ref }}
name: coverage-pull-request
path: coverage
- uses: actions/download-artifact@v4
with:
Expand Down

0 comments on commit 804920f

Please sign in to comment.