Change Exception to Throwable when Decoding #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When decoding an image, any Exception is being caught. This will catch a large majority of crashes, except for one of the most important when dealing with Images, OutOfMemoryException. The Exception class extends Throwable, so it will still continue to catch what it did before.
|
Generally the rule is never to catch Throwable because it leaves the JVM in an undefined state that may not be recoverable. I'm not certain whether this applies to the Dalvik/ART VMs for OutOfMemoryErrors, but given the goal of this view is to make OOMEs very unlikely I'm also not sure this a necessary change. |
|
I don't want to catch Throwable but catching OutOfMemoryError should be okay in almost all cases, so I'll close this PR and create an OutOfMemoryException class to wrap it, preserving backwards compatibility for the listener interface. |
davemorrissey
added a commit
that referenced
this pull request
Apr 3, 2016
… listeners can be called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catch a large majority of crashes, except for one of the most important
when dealing with Images, OutOfMemoryError. The Exception class
extends Throwable, so it will still continue to catch what it did
before.