Don't show download count, it's always -1 for PyPI #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davep
requested changes
Apr 19, 2024
pispy/data/package.py
Outdated
| @@ -42,9 +42,6 @@ class PackageURL(NamedTuple): | |||
| digests: dict[str, str] | |||
| """The digests for the URL.""" | |||
|
|
|||
| downloads: int | |||
| """The number of downloads for the URL.""" | |||
|
|
|||
There was a problem hiding this comment.
I'd prefer to still keep this in the class.
pispy/data/package.py
Outdated
| @@ -89,7 +86,6 @@ def from_json(cls, data: dict[str, Any]) -> "PackageURL": | |||
| return cls( | |||
| comment_text=url("comment_text"), | |||
| digests=url("digests", {}), | |||
| downloads=url("downloads", 0), | |||
There was a problem hiding this comment.
As mentioned elsewhere, I think I'd prefer to keep this in the class.
| @@ -208,7 +208,6 @@ def compose(self) -> ComposeResult: | |||
| ("MD5 Digest", self._url.md5_digest, Value), | |||
| ("Uploaded", self._url.upload_time_iso_8601, Value), | |||
| ("Has Signature", "Yes" if self._url.has_sig else "No", Value), | |||
| ("Downloads", f"{self._url.downloads:,}", Value), | |||
There was a problem hiding this comment.
Yeah, good call. I've even said a couple of times on stream while tidying this up that I should either filter out the -1 or just plain not show it anyway now.
|
Updated! |
hugovk
changed the title
|
Awesome, thanks. I know it seems a bit daft still loading the unused stuff anyway, but I was considering a sort of "show all values" toggle at some point, perhaps, maybe, possibly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downloads count is always -1 in the JSON response for PyPI packages, so we might as well not show it:
https://mail.python.org/pipermail/distutils-sig/2013-May/020855.html
That says 0, but it was later changed to -1 to make it more obviously not-real.
(It's possible other package indexes do return a download count, but it looks like this tool only checks PyPI, and I would expect that to be the most common one anyway.)