Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Readarr - an ebook collection manager for Usenet and BitTorrent users #580

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

bcurran3
Copy link
Contributor

@bcurran3 bcurran3 commented Aug 16, 2022

What this PR does / why we need it:

Adds Readarr - an ebook collection manager for Usenet and BitTorrent users

...because we can't be missing any of the arr programs now can we?!

Which issue (if any) this PR fixes:

Fixes #

Any other useful info:

@bcurran3 bcurran3 changed the title WIP: readarr add ADD: Readarr - an ebook collection manager for Usenet and BitTorrent users Aug 16, 2022
Copy link
Owner

@davestephens davestephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions and changes required on this PR.

roles/readarr/tasks/main.yml Show resolved Hide resolved
pull: true
volumes:
- "{{ readarr_data_directory }}/config:/config"
- "{{ books_root }}:/books"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please abstract this the same as readarr_downloads_root

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

readarr_download_directory: "{{ downloads_root }}"

# uid / gid
readarr_user_id: "998"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this uid / gid come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 998 is my ansible-nas user. I'll have to go test and figure out why I choose that long ago. Probably should be 1000 if 0 doesn't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to use root like all the other *arr linuxserver app defaults

pull: true
volumes:
- "{{ readarr_data_directory }}/config:/config:rw"
- "{{ books_root }}:/books:rw"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use the new variable you created - I wouldn't expect to see books_root here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Done.
(I swear I did this yesterday!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants