dwc_otg: prevent leaking URBs during enqueue

A dwc_otg_urb would get leaked if the HCD enqueue function failed for any reason. Free the URB at the appropriate points.
davet321 · Oct 22, 2013 · 4d2caeb · 4d2caeb
1 parent d3a2533
commit 4d2caeb
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/drivers/usb/host/dwc_otg/dwc_otg_hcd_linux.c b/drivers/usb/host/dwc_otg/dwc_otg_hcd_linux.c
@@ -797,11 +797,19 @@ static int dwc_otg_urb_enqueue(struct usb_hcd *hcd,
 #if USB_URB_EP_LINKING
  usb_hcd_unlink_urb_from_ep(hcd, urb);
 #endif
+ DWC_FREE(dwc_otg_urb);
  urb->hcpriv = NULL;
  if (retval == -DWC_E_NO_DEVICE)
  retval = -ENODEV;
  }
  }
+#if USB_URB_EP_LINKING
+ else
+ {
+ DWC_FREE(dwc_otg_urb);
+ urb->hcpriv = NULL;
+ }
+#endif
  DWC_SPINUNLOCK_IRQRESTORE(dwc_otg_hcd->lock, irqflags);
  return retval;
 }