Skip to content

Commit

Permalink
Interesting note.
Browse files Browse the repository at this point in the history
An apparent limitation of vue-cli's SASS processing means we need to create a
new webpack loader to handle .scss partials. Potential solutions noted on issue
#2

For now, manually include core files in a basic assumed order.
  • Loading branch information
davewallace committed Apr 24, 2018
1 parent ec67bc0 commit 2063025
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 13 deletions.
5 changes: 1 addition & 4 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,8 @@
</template>

<style lang="scss">
/**
* All imports and contextual SCSS must be contained within this single style tag
*/
@import "style/reset.scss";
@import "style/variables.scss";
@import "style/reset.scss";
body {
background: $color__base;
Expand Down
5 changes: 1 addition & 4 deletions src/components/containers/SortableGrid.vue
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,8 @@
</template>

<style lang="scss">
/**
* All imports and contextual SCSS must be contained within this single style tag
*/
@import "../../style/reset.scss";
@import "../../style/variables.scss";
@import "../../style/reset.scss";
.sortable-grid {
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/Button.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@

<style scoped lang="scss">
@import "../../style/reset.scss";
@import "../../style/variables.scss";
@import "../../style/reset.scss";
@import "../../style/utility.scss";
.button {
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/Icon.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

<style scoped lang="scss">
@import "../../style/reset.scss";
@import "../../style/variables.scss";
@import "../../style/reset.scss";
i {
display: inline-block;
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/Layout.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

<style scoped lang="scss">
@import "../../style/reset.scss";
@import "../../style/variables.scss";
@import "../../style/reset.scss";
@import "../../style/utility.scss";
.layout-item {
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/Modal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@

<style lang="scss">
@import "../../style/reset.scss";
@import "../../style/variables.scss";
@import "../../style/reset.scss";
@import "../../style/utility.scss";
// applied to body element in response to modal component's visible state
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/Notification.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

<style scoped lang="scss">
@import "../../style/reset.scss";
@import "../../style/variables.scss";
@import "../../style/reset.scss";
.notification {
border: 2px dashed green;
Expand Down
2 changes: 2 additions & 0 deletions src/style/reset.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import "variables.scss";

/**
* Note that this reset handles only the very basic HTML elements
* in favour of BEM within components setting purposeful styles.
Expand Down

0 comments on commit 2063025

Please sign in to comment.