Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Copyright Message in Output #156

Merged
merged 8 commits into from
May 17, 2018
Merged

Conversation

zodiac403
Copy link
Contributor

@zodiac403 zodiac403 commented Mar 28, 2018

Hi @davglass

very happy to use the license-checker on Node projects. For a current project we need the copyright statement for some licenses.

I started adding this to extend this package for our needs. If you are interested in this feature, We could work on this PR to get it into a "deliverable" stage.

Update: Just saw, this could address issue #154

@zodiac403
Copy link
Contributor Author

zodiac403 commented Mar 30, 2018

Update: I did some more work on index.js. Now the copyright parser should only trigger, when it is defined in customFormat.

From my side, this PR is ready for a first review. I'll remove the "Work in Progress" label above. Any comments are welcome ;)

Not sure how you are handling the unit tests. Where is a good place to add some?

Best!

@zodiac403 zodiac403 changed the title Work in Progress: Display Copyright Message Display Copyright Message Mar 30, 2018
- Combine (c) statements that are spread over several lines.
- Assume double line breaks (\n\n) as end of the statement.
- Tolerate WINDOWS line endings.
@zodiac403 zodiac403 changed the title Display Copyright Message Include Copyright Message in Output May 16, 2018
@zodiac403
Copy link
Contributor Author

zodiac403 commented May 16, 2018

Hi @davglass
any thoughts on this PR?

@davglass
Copy link
Owner

This seems ok to me, but you need to rebase this off of master. Your PR build is passing now but will fail after the rebase due to the test coverage dropping. All of the tests are located in the tests directory and should be pretty easy to follow..

@zodiac403
Copy link
Contributor Author

zodiac403 commented May 17, 2018

Thx for the quick respone!

Added an unit test in the test.js, hope location and syntax fit the overall style. Would the new test coverage pass in master?

@davglass davglass merged commit a76098d into davglass:master May 17, 2018
@davglass
Copy link
Owner

Published in license-checker@20.0.0

@@ -178,7 +178,7 @@ var flatten = function(options) {
}

if (index === 0) {
// Treat the file with the highest precedense as licenseFile
// Treat the file with the highest precedence as licenseFile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, 🇬🇧 vs 🇺🇸 fight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants