-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Copyright Message in Output #156
Conversation
- Only trigger COPYRIGHT parser when configured. - Fix code analysis.
Update: I did some more work on index.js. Now the copyright parser should only trigger, when it is defined in customFormat. From my side, this PR is ready for a first review. I'll remove the "Work in Progress" label above. Any comments are welcome ;) Not sure how you are handling the unit tests. Where is a good place to add some? Best! |
- Combine (c) statements that are spread over several lines. - Assume double line breaks (\n\n) as end of the statement. - Tolerate WINDOWS line endings.
Hi @davglass |
This seems ok to me, but you need to rebase this off of master. Your PR build is passing now but will fail after the rebase due to the test coverage dropping. All of the tests are located in the |
Thx for the quick respone! Added an unit test in the |
Published in |
@@ -178,7 +178,7 @@ var flatten = function(options) { | |||
} | |||
|
|||
if (index === 0) { | |||
// Treat the file with the highest precedense as licenseFile | |||
// Treat the file with the highest precedence as licenseFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, 🇬🇧 vs 🇺🇸 fight
Hi @davglass
very happy to use the license-checker on Node projects. For a current project we need the copyright statement for some licenses.
I started adding this to extend this package for our needs. If you are interested in this feature, We could work on this PR to get it into a "deliverable" stage.
Update: Just saw, this could address issue #154