fix: missing isValid bounds check in getWidthHeightInKM is possible u…

…ndefined source for vehicleUpdates error

package.json

@@ -1,6 +1,6 @@
 {
   "name": "irish-buses",
-  "version": "0.14.0",
+  "version": "0.14.1",
   "type": "module",
   "scripts": {
     "dev": "next dev --experimental-https",

src/components/Map/MapContentLayer.tsx

@@ -85,6 +85,7 @@ function MapContentLayer({
 
   const getWidthHeightInKM = useCallback(() => {
     const bounds = map.getBounds();
+    if (!bounds.isValid()) return 0;
 
     const width =
       map.distance(bounds.getNorthWest(), bounds.getNorthEast()) / 1000;

src/components/changelog/changelogs.ts

@@ -4,6 +4,12 @@ export type Changelog = {
   title?: string;
 };
 export const changelogs: Changelog[] = [
+  {
+    version: "0.14.1",
+    changes: [
+      "Possible fix for vehicleUpdates api throwing error when it shouldn't.",
+    ],
+  },
   {
     version: "0.14.0",
     changes: [

src/pages/api/gtfs/vehicle-updates.ts

@@ -78,7 +78,9 @@ const handler: ApiHandler<VehicleUpdatesResponse> = async (
     typeof rad !== "string"
   ) {
     // shouldn't happen
-    console.error("Shouldn't happen: lat or lng was an array...");
+    console.error(
+      `Invalid vehicleUpdates query, expected strings, received: , lat: ${lat}, lng ${lng}, rad ${rad}`,
+    );
     res.status(StatusCodes.BAD_REQUEST).end();
     return;
   }
@@ -212,12 +214,10 @@ const handler: ApiHandler<VehicleUpdatesResponse> = async (
     // expire after 120 seconds
     await redis.expire(GEO_RECORDS_KEY, REDIS_CACHE_EXPIRE_SECONDS);
 
-    return res
-      .status(200)
-      .json({
-        vehicleUpdates: vehiclesWithinRadius,
-        timestamp: String(timestamp),
-      });
+    return res.status(200).json({
+      vehicleUpdates: vehiclesWithinRadius,
+      timestamp: String(timestamp),
+    });
   } catch (error) {
     throw error;
   } finally {