[DRAFT] feat: use backend to render browser columns #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moves save/load into CardBrowserColumn * Use the enum values, rather than the indices Prep for Issue 11889
Breaking! Updates the default columns from: * QUESTION, ANSWER to * Cards: [Sort Field, Card Type, Due, Deck] * Notes: [Sort Field, Note Type, Card Type/Type Count, Tags] ---- improvements: * Support different columns for CARDS and NOTES mode * Support more than 2 columns (not yet usable in the UI) deprecates + upgrades shared prefs: * "cardBrowserColumn1" - index into `COLUMN1_KEYS` * "cardBrowserColumn2" - index into `COLUMN2_KEYS` now (shared prefs): * "activeCols" -> `|` separated list of column keys * "activeNoteCols" -> `|` separated list of column keys Prep for Issue 11889
For use in browserRowForId Prep for Issue 11889
removes strings: * browser_column1_headings * browser_column2_headings Prep for Issue 11889
unnecessary logging from logs of 'setColumn[1/2]'
david-allison
force-pushed
the
card-browser-rewrite-3
branch
2 times, most recently
from
ae0414c
to
8febcc7
Compare
david-allison
force-pushed
the
card-browser-rewrite-3
branch
from
8febcc7
to
1eb6386
Compare
david-allison
force-pushed
the
browser-refactor-columns
branch
from
eb7d7d5
to
8e54d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on the parent PR
Seeking feedback on:
card_browser_show_media_filenamesprobably wants to be removed?