Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solver UI - Object Relationships Feature Cannot be Disabled #222

Closed
david-cattermole opened this issue Jun 26, 2021 · 1 comment
Closed

Solver UI - Object Relationships Feature Cannot be Disabled #222

david-cattermole opened this issue Jun 26, 2021 · 1 comment
Assignees
@david-cattermole
Labels
bug maya tool A user tool inside Maya. user interface Related to a User Interface (Maya or Qt)
Milestone
v0.3.14

Comments

@david-cattermole
Copy link
Owner

Problem

In the Solver UI, when a Collection's "Object Relationships" checkbox is enabled, and the solver is run, then the checkbox is disabled and the solver is run, the effects of the "Object Relationships" checkbox being enabled is still observed.

Expected behavior:
When the "Object Relationships" checkbox is disabled the Object Relationships should have no affect.

Actual behavior:
After being enabled once, the "Object Relationships" feature persists and causes issues with the solver.

Steps to Reproduce

In the Solver UI, when a Collection's "Object Relationships" checkbox is enabled, and the solver is run, then the checkbox is disabled and the solver is run, the effects of the "Object Relationships" checkbox being enabled is still observed.

  1. Open Solver UI, for a basic solve set up.
  2. Run the Solver, with default values.
  3. Set "Object Relationships" checkbox to enabled, then run the solver.
  4. Set "Object Relationships" checkbox to disabled, then run the solver.
  5. The solver will not work the same as in step 2.

Software Versions

  • mmSolver version: v0.3.13 (perhaps previous versions too)
  • Maya version: All supported.
  • Operating System (OS): All supported.
@david-cattermole david-cattermole added bug maya tool A user tool inside Maya. user interface Related to a User Interface (Maya or Qt) labels Jun 26, 2021
@david-cattermole david-cattermole added this to the v0.3.14 milestone Jun 26, 2021
@david-cattermole david-cattermole self-assigned this Jun 26, 2021
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Add user preference 'Solver UI - Allow Object Relationships'.
9903ff3 
By default solving with object relationships is disabled,
but can be enabled.

Issue #222
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Add user preference 'Solver UI - Allow Object Relationships' to window.
bba879b 
The user can turn on/off the feature to automatically remove objects
that are not detected to be inside the solver.

Issue #222
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Bug fix: Only remove attributes/markers if requested to do so.
b5f7c2c 
The "remove unused" flags were previously incorrectly used, and
could ignore markers/attributes accidentally even when the user
did not expect/want that behaviour.

Issue #222.
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Make sure integers are stored as integer attributes on Collections.
be1f771 
Issue #222.
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Pass 'removeUnusedMarkers/Attributes' flags to mmSolver command.
d444f5a 
This feature will allow fully control the "remove unused objects"
feature, which is enabled when users want to calculate the
"Evaluate Object Relationships". For most tasks, this is not
needed to be enabled.

Issue #222
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Bug fix, ensure solver values are updated when current frame is solved.
584be63 
Issue #222
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Use preference to disable the "Eval Object Relationships" in Solver UI.
06e8360 
The user must enable the user preference
"Solver UI - Allow Object Relationships" in order to enable the
"Eval Object Relationships" feature in the Solver UI.

The solver updates the model each time the user "activates" the window.

Issue #222
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Keep track of all currently open instances of 'BaseMayaWindow'.
3c9a43b 
Issue #222
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Ability to close all open 'MayaBaseWindow' class windows.
3db9168 
This can be used to clean up while closing Maya, or
opening a new Maya scene file.

Issue #222
david-cattermole added a commit that referenced this issue Jul 4, 2021
@david-cattermole
Trigger event to close all windows when opening a new Maya scene file.
e435461 
This stops crashes from happening caused when opening a new Maya scene
while the window(s) (internally) still hold a pointer to some
deallocated memory (from the previously open Maya scene).

Closing all windows clears the memory and fixes the problem.

Issue #222.
@david-cattermole
Copy link
Owner Author

This issue has not been addressed, and merged into the develop_v0.3.x branch.

This issue ended up needing multiple sub-issue fixes (not documented in GitHub), including:

  • New user preference "Solver UI - Allow Object Relationships" added, off by default to avoid users using the feature unless they really want it.
  • The need to close all mmSolver windows when Maya needs to close the current Maya scene file (fixing crashes).
  • Changes to the internal mmSolver code to ensure markers/attributes are not removed, unless the user really wants the Eval Object Relationships feature enabled.
  • Minor bug fix when solving the current frame only.

This fix will be included in v0.3.14.

@david-cattermole david-cattermole mentioned this issue Jul 4, 2021
Closed
@david-cattermole david-cattermole mentioned this issue Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-cattermole david-cattermole

Labels
bug maya tool A user tool inside Maya. user interface Related to a User Interface (Maya or Qt)
Projects
None yet
Milestone
v0.3.14
Development

No branches or pull requests
1 participant
@david-cattermole