Add search for flashcards #34
Conversation
|
@david-swift I've used the I'm not sure if that is the most fitting UI element for search. Seems to be intended for less changing inputs, like flashcards, rather than often changing inputs. Your thoughts on that? |
Search now usable
Sources/View/EditView.swift
Outdated
| var flashcards: View { | ||
| ForEach(.init(set.flashcards.indices)) { index in | ||
| if set.flashcards[safe: index] != nil { | ||
| if let flashcard = set.flashcards[safe: index], | ||
| flashcard != nil && |
There was a problem hiding this comment.
This line is responsible for an error:
warning: comparing non-optional value of type 'Flashcard' to 'nil' always returns true
It could be changed back to
set.flashcards[safe: index] != nil &&I'm not sure if it can be left out. I'm unwrapping the flashcard one line above, so this check should be obsolete now, right?
There was a problem hiding this comment.
Yes, the if let flashcard = set.flashcards[safe: index] assigns a nonoptional value to flashcard so flashcard cannot be nil (because of its nonoptional type) where you are checking it. So you could remove the flashcard != nil check.
|
Thank you so much 🙏😀 I think it makes more sense to filter the array containing the flashcards itself (similar to the line here for filtering sets) because one can change the order based on how close the content actually is. We could convert the provided example into a function and use it in both cases. Instead of using an entry row, we could add a search button that opens a search entry (similar to the one in the sidebar) to the left of the toolbar in the editing dialog (and make |
|
Edit: |
|
I think the set filtering should be rebranded to set searching to have a consistent wording.
The
|
Move func search() from struct FlashcardsSet Apply func score() from struct FlashcardsSet to struct Flashcard Create protocol SearchScore for func sortScore() to sort both [FlashcardsSet] and [Flashcard] !! Does not work in practice !!
It doesn't matter whether a function is defined directly on the type or in an extension for the type, the result is exactly the same. We can use the same code for searching sets in the sidebar and check whether the edit mode is active, if yes open the search bar in the edit view, otherwise in the sidebar. I can implement this. I want to keep the button for searching sets in the menu as it is, I think, a very uncommon action, especially after #10 is implemented. I agree that set filtering should be renamed to searching. Concerning your last comment, I took a look at your code and updated it so that it works now. See 774bde3. Thank you so much for working on this! |
|
As you are learning Swift, here some technical information about the previous commit. The problem you were facing is described here. The solution in this case were generics. You might also want to take a look at type extensions in Swift. |
|
Ah, okay. Thanks for compiling this information. Will definitely be helpful! As someone who mainly programs in C, it's really great to know that a language takes care of things like this 😅 |
|
Sorry for the force push, didn't see the variable renames and did a |
|
Search only working for the back of flashcards |
|
This should be it |
|
Not sure whether suchen or durchsuchen is better - maybe rather durchsuchen (for both sets and cards)? |
|
I think suchen is the correct word. Durchsuchen is colloquial and emphasizing of suchen. |
|
I changed my opinion. I think searching should not change the order of the flashcards as this is more confusing than simply hiding the irrelevant flashcards and keeping the order. What do you think about this implementation, @konstantintutsch? |
|
I agree. This change makes it less confusing. 👌 |
Steps
Purpose
Editing/fixing flashcards in large sets is a pain. A search for the content on the front or back of the flashcard fixes the issue.
Approach
If clause in
var flashcards: View { ForEach() }in EditView.swiftThis is my first time writing in Swift, don't expect the cleanest code. Review definitely necessary 😬