Add --dwarf-start=0 option to remove the file path in the output
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! The change looks good. The test failure seems caused by deprecated package, I will check how to fix it. |
david942j
reviewed
Jul 8, 2023
lib/one_gadget/fetchers/objdump.rb
Outdated
| @@ -31,7 +31,12 @@ def extra_options=(options) | |||
| # @param [Integer] stop The end address. | |||
| # @return [String] The CLI command to be executed. | |||
| def command(start: nil, stop: nil) | |||
| cmd = [bin, '--no-show-raw-insn', '-w', '-d', *@options, @file] | |||
| # --dwarf-start=0 is to make sure `suppress_bfd_header` is true to eliminate the information that includes the file path: | |||
There was a problem hiding this comment.
lib/one_gadget/fetchers/objdump.rb:34:121: C: Layout/LineLength: Line is too long. [129/120] (https://rubystyle.guide#max-line-length)
# --dwarf-start=0 is to make sure suppress_bfd_header is true to eliminate the information that includes the file path:
There was a problem hiding this comment.
Ok, done :)
I moved some details to #204, hopefully this problem has been resolved now.
lebr0nli
force-pushed
the
fix-bad-objdump-output
branch
from
15be7e3
to
fbc2a47
Compare
|
Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably resolve #204