add constants used by alternate saver of patchelf.rb #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase, I just fixed the CI issues. |
david942j
requested changes
Aug 21, 2020
lib/elftools/constants.rb
Outdated
| @@ -95,6 +95,7 @@ module DT | |||
| DT_VERDEF = 0x6ffffffc # address of version definition table | |||
| DT_VERDEFNUM = 0x6ffffffd # number of entries in {DT_VERDEF} | |||
| DT_VERNEED = 0x6ffffffe # address of version dependency table | |||
| DT_VERSYM = 0x6ffffff0 # section address of .gnu.version. | |||
lib/elftools/constants.rb
Outdated
| @@ -212,6 +213,15 @@ def self.mapping(type) | |||
| end | |||
| include ET | |||
|
|
|||
| # segment permission flags, bitwise ored value is recorded in +p_flags+ | |||
There was a problem hiding this comment.
Make it a sentence (i.e. capitalize, add period)
Same below
These constants are used by alternate saver of patchelf.rb
rmNULL
force-pushed
the
master
branch
3 times, most recently
from
a99bdb9 to
e897f8d
Compare
|
good now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constants required for david942j/patchelf.rb#28