Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following ELF file:
Before this pull request,
offset_from_vma(0x30000)
would return0x2F000
which is a part of the first segment when it instead should be the first offset of the latter segment, i.e.0x3E000
.This was due to the default size of zero.
vma_in?
searches from the offset inclusive to the offset + size exclusive. When size = 0 the starting offset is counted as exclusive and thus uses the first segment. For correct calculations, the minimum range must be 1.