Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with local SSH keys #9

Closed
cecton opened this issue Feb 8, 2020 · 2 comments · Fixed by #10
Closed

Not working with local SSH keys #9

cecton opened this issue Feb 8, 2020 · 2 comments · Fixed by #10

Comments

@cecton
Copy link
Contributor

cecton commented Feb 8, 2020

First thank you for your work!

I have tried this crate today and I found out that it is using the SSH agent. So I killed the daemon 😈 and try again and now it says: error authenticating: failed connecting with agent; class=Ssh (23)

I have the impression that this crate doesn't handle at all the id_rsa and id_rsa.pub in the $HOME/.ssh

Is it supported? Do you intend to support it? (Do you want a PR?)

@davidB
Copy link
Owner

davidB commented Feb 8, 2020

Hi,

Thanks for the feedback. you are right it doesn't handle well all the key (id_rsa, id_ed25519 or any name).

PR are welcome.

You can start at https://github.com/davidB/git2_credentials/blob/master/src/lib.rs#L163

cecton added a commit to cecton/git2_credentials that referenced this issue Feb 9, 2020
@davidB davidB closed this as completed in #10 Feb 9, 2020
davidB pushed a commit that referenced this issue Feb 9, 2020
@cecton
Copy link
Contributor Author

cecton commented Feb 13, 2020

Thank you for the release 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants