Add support for 2.2.0-rc20 #77
Comments
davidalger
added a commit
that referenced
this issue
Aug 18, 2017
davidalger
added a commit
that referenced
this issue
Aug 18, 2017
davidalger
added a commit
that referenced
this issue
Aug 18, 2017
davidalger
added a commit
that referenced
this issue
Aug 18, 2017
…ipt altogether #77 There is no point in leaving this code in here when it only applies to 2.1.1 and 2.1.2 specifically, thus having very minimal benefit (an every so slightly faster deploy on those older versions)
davidalger
added a commit
that referenced
this issue
Aug 18, 2017
davidalger
added a commit
that referenced
this issue
Aug 18, 2017
…ls 2.2 and no longer needed with minimum version req) #77
davidalger
added a commit
that referenced
this issue
Aug 19, 2017
- Remove string based error checking (this actually will fails 2.2 since the output of static content deploy is not the same and only outputs on stderr); no longer needed with minimum Magento 2.1.1 version requirement - Only use pipefail and dot removal on versions prior to 2.2.0 for cleaner execution on later versions - Use execute vs capture since we no longer need to inspect output for errors
davidalger
added a commit
that referenced
this issue
Aug 19, 2017
davidalger
added a commit
that referenced
this issue
Aug 19, 2017
tunght13488
added a commit
to tunght13488/capistrano-magento2
that referenced
this issue
Sep 23, 2017
* upstream/master: (34 commits) Updated code comment for accuracy Release prep Updated double run of static content deploy to only apply to versions prior to 2.1.8 Reverted 4f246bd; fix noted in release notes for Magento 2.1.8 was inaccurate Fixed deploy routine so production mode is no longer enabled automatically when `:magento_deploy_production` is false Release prep Removed TODO file Update TODO Added tasks to set and show the current deploy mode davidalger#77 Remove --no-ansi flags; they are not necessary since we are no longer capturing and checking output Strip out old multi-tenant compiler use (it was removed for core in 2.1) davidalger#77 Updated TODO Updated CL and README davidalger#77 Added comment describing why we touch the deployed_version.txt file Eliminated the second (secure) run of static content deploy when deploying 2.2.0-rc or later davidalger#77 Clean up static content deployment davidalger#77 Micro-optimized the pre-deployment version check davidalger#77 Simply static content deploy by just dropping the use of --no-javascript altogether davidalger#77 Cleanup warnings / special cases for Magento 2.1.0 and earlier; davidalger#77 Added 2.1.8 maximum version to the workaround added for multi-lingual site deployment; see issue davidalger#72 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Magento 2.2 has changed the behavior of (at minimum) the static content deployment execution. It will not operate where MAGE_MODE is not set to production (unless you also specify -f) and it no longer outputs the same success/failure messages where were being checked (in addition to relying on exit codes for support deploying 2.1.0 and earlier where nonzero exit codes were not returned).
This appears to be the appropriate time to drop support for 2.1.0 and newer, raising the requirements to Magento 2.1.1 or later. It will also allow cleanup of a few other things such as duplicate composer install commands.
The text was updated successfully, but these errors were encountered: