-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Selenium] Update selenium to standalone latest version #349
Merged
davidalger
merged 3 commits into
wardenenv:develop
from
magenius-team:selenium-standalone
May 4, 2021
Merged
[Selenium] Update selenium to standalone latest version #349
davidalger
merged 3 commits into
wardenenv:develop
from
magenius-team:selenium-standalone
May 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Den4ik
changed the title
[Env] Update selenium to standalone latest version
[Selenium] Update selenium to standalone latest version
Apr 15, 2021
davidalger
requested changes
Apr 22, 2021
Co-authored-by: David Alger <davidmalger@gmail.com>
Den4ik
changed the title
[Selenium] Update selenium to standalone latest version
WIP: [Selenium] Update selenium to standalone latest version
Apr 23, 2021
Den4ik
changed the title
WIP: [Selenium] Update selenium to standalone latest version
[Selenium] Update selenium to standalone latest version
Apr 25, 2021
@davidalger Thanks for review. PR updated |
davidalger
approved these changes
May 4, 2021
@Den4ik Everything looks good. Appreciate it. |
@Den4ik Are you sure that Magento Functional Testing framework supports the latest version? |
Yes, I used it when worked on magento/magento2#32090 |
Wow. That's awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update usage of 2 containers of selenium-hub and node-chrome with one standalone.
node-chrome released 3 years ago and has old version of chrome.
After update node-chrome to latest I faced with problems.
Standalone container contain both hub and chrome driver.