Updates MFTF configuration with notes about some common issues #268
Conversation
…default `magento2` environment type
|
Hopefully my formatting here is acceptable - I wasn't sure where the information should go - if anyone has a better suggestion, just holler at me and I'll adjust. |
There was a problem hiding this comment.
Lots of good info here, thank you! Posed a number of questions inline with the changes. The driving force behind them is: Let's get these necessary changes into the base templates for Selenium support, unless there is a good reason not to, rather than making the setup require more manual effort to function.
docs/configuration/mftf.md
Outdated
| extra_hosts: | ||
| - ${TRAEFIK_SUBDOMAIN:-app}.${TRAEFIK_DOMAIN}:${TRAEFIK_ADDRESS:-0.0.0.0} | ||
| environment: | ||
| - START_XVFB=false |
There was a problem hiding this comment.
@Lunaetic @lbajsarowicz Any reason this change couldn't/shouldn't be simply made in the Warden default environment spec for MFTF? Doesn't make sense to me to include a broken Selenium setup (even if it's not really our fault) and then have a doc saying how to override it with one that works.
docs/configuration/mftf.md
Outdated
|
|
||
| ``` | ||
| client_max_body_size 100M; | ||
| ``` |
There was a problem hiding this comment.
This should be embedded in the /etc/nginx/nginx.conf within the Nginx image. No reason users should need to set a custom Nginx setting here. Looking at the role I've used for Nginx in production, the default value I've used there has been 200m, so let's go with that.
There was a problem hiding this comment.
Clarification - when you say "embedded in the nginx.conf within the Nginx image"; do you mean "added to the docker.io image"?
There was a problem hiding this comment.
I've created the following images using wardenenv/nginx:1.16 and wardenenv/nginx:1.17 as bases that include this change in the nginx.conf files - I've tested them, however I'm not sure what the process is to update the containers in warden. Do they get pulled into the wardenenv/ repo, or is updating the base.nginx.yml file to point at them acceptable?
docs/configuration/mftf.md
Outdated
| version: "3.5" | ||
| services: | ||
| selenium-chrome: | ||
| shm_size: '1gb' |
There was a problem hiding this comment.
@Lunaetic @lbajsarowicz Is this shm_size fairly static or can it fluctuate? I.e. if we change the MFTM support to use chrome vs the spoke/hub (as it is currently) the shm_size should just be set in the defaults. If it's a fairly static need for this to be 1gb, then it can simply be used, otherwise it could be made a variable. Thoughts?
There was a problem hiding this comment.
1gb was an arbitrary size I chose while working on it; variable works, thanks
There was a problem hiding this comment.
Created a variable, set to 128mb, which still allows the tests to run from my testing.
|
@davidalger Gotcha - I'll update this PR with the suggested changes this week |
|
Closing in favor of #349 |
Updates mftf.md with several notes regarding getting it running in a default
magento2environment type.