Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test + code to copy properties from the old function to wrapped function #11

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

eXigentCoder
Copy link

Hey there

Someone who uses my library recently ran into an issue with the two libraries working together. The reason for the issue is that when wrapping the existing function, the old properties on the function were not being copied across to the new function.

In this PR is a test that was failing before the code change and passing now as well as the code to copy the properties across.

Thanks a lot!

@jdnichollsc
Copy link

@eXigentCoder Woww thanks for the contribution to use express in the best way!

@jdnichollsc
Copy link

@davidbanham what do you think? 👍

@davidbanham
Copy link
Owner

Looks great to me! Sorry it took a couple days to review, was busy with family over the weekend.

@eXigentCoder Many thanks for the excellent PR! Will merge now.

I'm going to bump the major for this release on NPM since it's a change to the external API. I don't think it'd be likely to break anyone's code, but better safe than sorry.

@davidbanham davidbanham merged commit d87696c into davidbanham:master Jun 3, 2018
@davidbanham
Copy link
Owner

Live on NPM as 3.0.0 now.

https://www.npmjs.com/package/express-async-errors

@gr2m
Copy link

gr2m commented Jun 4, 2018

Could you add some changelogs somewhere? First place I usually look for is a GitHub release with the same version number: https://github.com/davidbanham/express-async-errors/releases but there is none yet, 2nd place a CHANGELOG.md file. Probot is using express-async-errors :) probot/probot#559

@eXigentCoder
Copy link
Author

An absolute pleasure, glad I was able to contribute!

@davidbanham
Copy link
Owner

@gr2m Thanks for spotting that. I had tagged it, but the remote didn't get updated due to an authentication snafu. I've pushed it now.

Have also added some release notes.

https://github.com/davidbanham/express-async-errors/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants