Avoid using eval() to get global object. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
@davidbau any plans to merge this in soon? I'm also on a project that needs this eval removed for CSP reasons and it would be great to not have to maintain a fork in parallel to this! |
|
Look great. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #64, this PR avoids using
eval()to get the global object, which causes this package to be unusable if a server has set Content-Security Policy (CSP) protocols. I use the Universal Module Definition (UMD) pattern, bringing back the way we inject the global object into the function via its arguments.I should also note that there is a stage-3 ECMAScript proposal for
globalThis, which is meant to address exactly this problem. Some browsers and environments have begun to implementglobalThisbut even if we were to use it now, we would still need a fallback toselforthis. Let me know if you would like to useglobalThisnow, but I can also understand waiting for the proposal to be finalized first.Let me know if there's anything else I should do to finish this PR! Thanks!