Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow verbs #11

Closed
Wes4329 opened this issue Jun 27, 2022 · 2 comments
Closed

allow verbs #11

Wes4329 opened this issue Jun 27, 2022 · 2 comments
Assignees
@davidberenstein1957
Labels
enhancement New feature or request

Comments

@Wes4329
Copy link

Wes4329 commented Jun 27, 2022

Looks like patterns currently prevent verbs?
individual_pattern = {
"lemma": {"regex": r"(?i)" + word},
"POS": {"NOT_IN": ["VERB"]},
"DEP": {"NOT_IN": ["nsubjpass"]},
}
@davidberenstein1957 davidberenstein1957 added the enhancement New feature or request label Jun 28, 2022
@davidberenstein1957 davidberenstein1957 self-assigned this Jun 28, 2022
@davidberenstein1957
Copy link
Owner

Thank you for the feedback. I'm taking a look now.

davidberenstein1957 added a commit that referenced this issue Sep 24, 2022
@davidberenstein1957
resolved issue #11 by adding more excplicit options to exclude POS an…
a03dddc 
…d DEPS from matching. Also, added n-gram token matching. Embedding for ¨new_york¨ would be matched as a single entry.
@davidberenstein1957
Copy link
Owner

@Wes4329 this can now be done via a variable during initialization exclude_pos, which determines what POS ought to be excluded from the matching.

davidberenstein1957 added a commit that referenced this issue Sep 26, 2022
@davidberenstein1957
resolved #11 by removing obsolete deepcopies
ad741d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidberenstein1957 davidberenstein1957

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidberenstein1957 @Wes4329