Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(package): add "exports" field" #506

Closed
wants to merge 1 commit into from

Conversation

remcohaszing
Copy link

This reverts commit e82e873.

Closes #505

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #506 (f677479) into master (bb49f39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files           1        1           
  Lines        1150     1150           
=======================================
  Hits         1093     1093           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb49f39...f677479. Read the comment docs.

Copy link

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be the simplest fix for now!

@davidbonnet
Copy link
Owner

Indeed, but 45203ca fixes the export map.

@davidbonnet davidbonnet closed this Apr 7, 2021
@wooorm
Copy link

wooorm commented Apr 11, 2021

that’s also a good solution! Thanks @davidbonnet!

@remcohaszing remcohaszing deleted the fix-imports branch August 22, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 1.7.3 breaks imports
3 participants