Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Req] Lock row #6

Open
jmiezitis opened this issue Apr 23, 2021 · 4 comments
Open

[Feature Req] Lock row #6

jmiezitis opened this issue Apr 23, 2021 · 4 comments

Comments

@jmiezitis
Copy link

The simplicity of this is astounding and does exactly what I wanted. Thank you.

Would be nice to be able to indicate that once I have got the subnet I need, say a /25, to then "lock" that row and visually indicate the row has been locked by perhaps changing the background colour. Even better would be to add a text field so I can indicate what the subnet is allocated to.

I can then concentrate on the other "available" subnets.

Cheers.
@BlackthornYugen
Copy link
Contributor

Cool idea, would you envision something like this then? Join & Divide buttons are disabled when locked?

image

Lock might prompt the user for the comment?
Or the comment can just be a text area that is visible regardless of lock state?

@BlackthornYugen
Copy link
Contributor

image

@BlackthornYugen
Copy link
Contributor

Work in progress up at https://subnets.jskw.ca/ but I am having trouble disabling the correct join buttons. I'll probably make a PR for the comment column after I clean up my code a bit this weekend.

BlackthornYugen added a commit to BlackthornYugen/subnets that referenced this issue Apr 25, 2021
@BlackthornYugen
Adding comments column ( Feature Request davidc#6 )
cd08abc 
Added ability to add comments. Adding a comment disables join/divide for
that network.
BlackthornYugen added a commit to BlackthornYugen/subnets that referenced this issue Apr 25, 2021
@BlackthornYugen
Adding comments column ( Feature Request davidc#6 )
ac9818f 
Added ability to add comments. Adding a comment disables join/divide for
that network. Adjusted colours on joins that cannot be clicked.
BlackthornYugen added a commit to BlackthornYugen/subnets that referenced this issue Apr 25, 2021
@BlackthornYugen
Adding comments column ( Feature Request davidc#6 )
22ae724 
Added ability to add comments. Adding a comment disables join/divide for
that network. Adjusted colours on joins that cannot be clicked.
BlackthornYugen added a commit to BlackthornYugen/subnets that referenced this issue Apr 25, 2021
@BlackthornYugen
Adding comments column ( Feature Request davidc#6 )
371a6e7 
Added ability to add comments. Adding a comment disables join/divide for
that network. Adjusted colours on joins that cannot be clicked.
BlackthornYugen added a commit to BlackthornYugen/subnets that referenced this issue May 3, 2021
@BlackthornYugen
Adding comments column ( Feature Request davidc#6 )
8299a07 
+ Added ability to add comments. Adding a comment disables join/divide
  for that network. Adjusted colours on joins that cannot be clicked.

+ Fixed CSS bug so hand cursor is shown as intended over
  maskSpanJoinable elements.
BlackthornYugen added a commit to BlackthornYugen/subnets that referenced this issue Feb 13, 2022
@BlackthornYugen
Adding comments column ( Feature Request davidc#6 )
4eb3c18 
+ Added ability to add comments. Adding a comment disables join/divide
  for that network. Adjusted colours on joins that cannot be clicked.

+ Fixed CSS bug so hand cursor is shown as intended over
  maskSpanJoinable elements.
@jmiezitis
Copy link
Author

This works for me! Again, nice work.
Apologies for the delayed response. I didn't have the right notification settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmiezitis @BlackthornYugen