feat: Add auto fix capability to onClick rule when data-test-id attribute is missing #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bkonuwa
commented
Jan 5, 2021
bkonuwa
commented
- feat: Add auto fix capability to onClick rule when data-test-id attribute is missing.
…bute is missing (#1) * feat: Add auto fix capability to onClick rule when data-test-id attribute is missing. * cleaned up parserOptionsMapper from onClick rule and used the generic parserOptionMapper instead * removed unused code Co-authored-by: Boima Konuwa <boima.konuwa@cision.com>
bkonuwa
changed the title
|
Thank you very much for submitting this, complete with tests! Will have a look when I get a chance. |
…names fix: Allow multipart jsx node names, data-qa on new line for multiline jsx open tags.
|
Thank you again, and sorry for the delay! I really need to setup some Github Actions to run tests automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.