fix-body-scroll-lock-compatibility #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I use react-input-range in modal window togather with bodyScrollLock.
bodyScrollLock has
event.stopPropagation();in it'shandleScrollmethod: https://github.com/willmcpo/body-scroll-lock/blob/master/src/bodyScrollLock.js#L136handleScroll is being triggered by
ontouchmoveevent. Since it hasstopPropagationontouchmoveevent of react-input-range is not being triggered (listeners are on document).https://github.com/davidchin/react-input-range/blob/master/src/js/input-range/slider.jsx#L119
That's why it's not working with bodyScrollLock.
In this PR I added
useCaptureparameter for listeners to force capturing phase andstopPropagationfor handlers which is being called when we're movingSlideronly.