Stubs: missing doc comments for __construct()

[kakserpom]

Example

Extension Code:

use ext_php_rs::prelude::*;

#[php_class]
struct Foo {}
#[php_impl]
impl Foo {
    /// Some docs
    ///
    /// Zzzz
    pub fn __construct(foo: &str) -> Self {
        Self {}
    }

    /// Some docs
    ///
    /// Zzzz
    pub fn someMethod() {}
}

#[php_module]
pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
    module.class::<Foo>()
}

Actual Behavior

<?php

// Stubs for untitled5

namespace {
    class Foo {
        /**
         * Some docs
         *
         * Zzzz
         */
        public static function someMethod() {}

        public function __construct(string $foo) {}
    }
}

PHP Version

PHP 8.4.8 (cli) (built: Jun  3 2025 16:29:26) (ZTS)
Copyright (c) The PHP Group
Built by Shivam Mathur
Zend Engine v4.4.8, Copyright (c) Zend Technologies
    with Zend OPcache v8.4.8, Copyright (c), by Zend Technologies

ext-php-rs Version

1de4bee

[kakserpom]

Still no comments after:

cargo install --git https://github.com/davidcole1340/ext-php-rs.git --branch master
cargo php stubs

[kakserpom]

@Xenira reopen pls

[Xenira]

The change was not in the cargo-php crate. You need to update ext-php-rs dependency. Running cargo php stubs in the tests directory on master works for me.

[...]
 class TestClassArrayAccess implements ArrayAccess {
        public function offsetExists(mixed $offset): bool {}

        public function offsetGet(mixed $offset): bool {}

        public function offsetSet(mixed $_offset, mixed $_value): mixed {}

        public function offsetUnset(mixed $_offset): mixed {}

        /**
         * Constructor
         * doc
         * comment
         */
        public function __construct() {}
    }
[...]

[kakserpom]

@Xenira right, it works now. Just a nitpick: __construct() is at the end of the stubs file despite being at the beginning of the corresponding struct php_impl.

[Xenira]

ye, but does that really matter? Stubs are mainly for LSPs and not really for humans. If you like you can create a MR. I personally do not care :)