Returning $this

[kakserpom]

#[php_class]
struct Foo {}
#[php_impl]
impl Foo {
    pub fn someMethod(&mut self) -> &mut Self {
        self
    }
}

error[E0277]: the trait bound `&mut PhpClassImplCollector<Foo>: IntoZval` is not satisfied
 --> src/lib.rs:7:37
  |
7 |     pub fn someMethod(&mut self) -> &mut Self {
  |                                     ^^^^^^^^^ the trait `IntoZval` is not implemented for `&mut PhpClassImplCollector<Foo>`
  |

[Xenira]

Seems like a regression because of the PhpClassImplCollector that was introduced with the new macro system.

[Xenira]

Ok, not directly related to that.

Root cause is:

error[E0507]: cannot move out of a mutable reference
   --> src/lib.rs:6:1
    |
6   | #[php_impl]
    | ^^^^^^^^^^^
    | |
    | value moved due to this method call
    | move occurs because value has type `Foo`, which does not implement the `Copy` trait
    |
note: `set_zval` takes ownership of the receiver `self`, which moves value
   --> /home/ls/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ext-php-rs-0.14.1/src/convert.rs:181:17
    |
181 |     fn set_zval(self, zv: &mut Zval, persistent: bool) -> Result<()>;
    |                 ^^^^

Not really a regression. Could you try this:

https://davidcole1340.github.io/ext-php-rs/types/class_object.html#returning-a-reference-to-self

But would still be great to support this.

[kakserpom]

Yes, I've seen this before, It still works.

It would be great to make it look pretty, however.

[Xenira]

Yeah, will keep this open. Think it would be great to support this.

Just not treating it as a regression that needs immediate fixing :)

[kakserpom]

@Xenira this self_ pattern fails if you need to take any reference as an argument, including &Zval.

Example:

use ext_php_rs::{prelude::*, types::ZendClassObject};
use ext_php_rs::types::Zval;

#[php_class]
pub struct Example {}

#[php_impl]
impl Example {
    pub fn some_method(
        self_: &mut ZendClassObject<Example>,
        arg: &Zval,
    ) -> &mut ZendClassObject<Example> {
        self_
    }
}

#[php_module]
pub fn get_module(module: ModuleBuilder) -> ModuleBuilder {
    module.class::<Example>()
}

error[E0106]: missing lifetime specifier
  --> src/lib.rs:12:10
   |
10 |         self_: &mut ZendClassObject<Example>,
   |                -----------------------------
11 |         arg: &Zval,
   |              -----
12 |     ) -> &mut ZendClassObject<Example> {
   |          ^ expected named lifetime parameter
   |
   = help: this function's return type contains a borrowed value, but the signature does not say whether it is borrowed from `self_` or `arg`
help: consider introducing a named lifetime parameter
   |
9  ~     pub fn some_method<'a>(
10 ~         self_: &'a mut ZendClassObject<Example>,
11 ~         arg: &'a Zval,
12 ~     ) -> &'a mut ZendClassObject<Example> {
   |

[kakserpom]

@Xenira could you please take a look? I am still unable to take &Zval and self_.